Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bluetooth] Remove settings cog next to Bluetooth toggle #795

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

git-f0x
Copy link
Contributor

@git-f0x git-f0x commented Dec 3, 2024

This removes extra horizontal padding from the applet list, which caused misalignment.
Didn't notice it with the previous PR.

Edit: The second commit should fix #797. I think the logic is correct (or more the removal of it), but have no idea how to test.
Should also fix #708 on the Bluetooth page, since it seems settings::item_row causes the issue, while settings::item::builder works properly.

@git-f0x git-f0x changed the title [Applet list] Remove extra padding [Bluetooth] Remove settings cog next to Bluetooth toggle Dec 4, 2024
@git-f0x git-f0x force-pushed the master branch 2 times, most recently from 952508a to e37e84e Compare December 4, 2024 02:38
@git-f0x git-f0x requested a review from wash2 December 4, 2024 16:52
This makes the page behave as if the settings cog toggle is always enabled.
@wash2 wash2 merged commit d01e0d8 into pop-os:master Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants