Add better logging #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
poolski
commented
Jan 16, 2024
poolski
commented
- Add better error logging/handling
- Update vendor dependencies
Rather than just returnin an error, wrap where the error has come from so we know what's borked a bit better.
If we don't have this configured, the app has no way to know what sensor to read. Previously the value was hard-coded which was stupid, since not everyone is me and don't have all the same sensor values.
Don't just panic if we don't get the expected number of results from the API. Instead, return a sensible error so the user doesn't see a horrible stacktrace.
poolski
force-pushed
the
add-more-logging
branch
from
43d49dc to
de376a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.