Fix URL parsing and config #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that I'd accidentally hard-coded my own Home Assistant URL into the dialer (no you can't access it, go away). The actual bug, however, was that the code wasn't - Reading the base URL from the config file - Detecting whether we're using HTTP/HTTPS - Converting it into a usable `ws://` URL for the dialer. That's fixed now.
Rather than using `fmt.Scanln` we can use a lightweight prompt library to hide things like the API key. I also noticed that the code doesn't validate the URL that the user inputs so if they write some gibberish, it might not even work as a URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code wasn't:
ws://URL for the dialer.💪🏻 Improve user config input
Rather than using
fmt.Scanlnwe can use a lightweight prompt library to hide things like the API key.I also noticed that the code doesn't validate the URL that the user inputs so if they write some gibberish, it might not even work as a URL.
🔧 Added an
insecureflag (-i | --insecure) to the app so that it can be run against Home Assistant instances which use a self-signed certificate