fixed minor issues

README.md

@@ -202,6 +202,9 @@ Documentation
 
 Release Notes
 -------------
+### 2019-01-06 - `v3.0.2`
+* fixed minor bugs
+
 ### 2019-01-04 - `v3.0.1`
 * Use shallow cloning to avoid downloading the (unused) project history
 

jamba.cmake

@@ -6,7 +6,7 @@ set(JAMBA_ROOT ${CMAKE_CURRENT_LIST_DIR})
 #-------------------------------------------------------------------------------
 set(JAMBA_MAJOR_VERSION 3)
 set(JAMBA_MINOR_VERSION 0)
-set(JAMBA_PATCH_VERSION 1)
+set(JAMBA_PATCH_VERSION 2)
 execute_process(COMMAND git describe --long --dirty --abbrev=10 --tags
     RESULT_VARIABLE result
     OUTPUT_VARIABLE JAMBA_GIT_VERSION

src/cpp/pongasoft/Utils/Constants.h

@@ -15,13 +15,14 @@
  *
  * @author Yan Pujante
  */
-
+#pragma once
 #include <pluginterfaces/base/ftypes.h>
 
 namespace pongasoft {
 namespace Utils {
 
 constexpr Steinberg::int32 MAX_INT32 = 0x7fffffff;
+constexpr auto ZERO_INT32 = static_cast<Steinberg::int32>(0);
 
 }
 }

src/cpp/pongasoft/VST/AudioBuffer.h

@@ -343,7 +343,7 @@ class AudioBuffers
     }
 
     if(getNumChannels() > 0)
-      fBuffer.silenceFlags == (static_cast<uint64>(1) << getNumChannels()) - 1;
+      fBuffer.silenceFlags = (static_cast<uint64>(1) << getNumChannels()) - 1;
 
     return kResultOk;
   }

src/cpp/pongasoft/VST/GUI/Params/GUIParamCxMgr.h

@@ -190,16 +190,15 @@ class GUIParamCxMgr
   }
 
   /**
- * Registers the ser param only given its id and return the wrapper to the param.
- *
- * @return the wrapper which may be empty if the param does not exists or is of wrong type (use .exists)
- */
+   * Registers the ser param only given its id and return the wrapper to the param.
+   *
+   * @return the wrapper which may be empty if the param does not exists or is of wrong type (use .exists)
+   */
   template<typename T>
   GUIJmbParam<T> registerJmbCallback(ParamID iParamID,
                                      Parameters::ChangeCallback iChangeCallback,
                                      bool iInvokeCallback)
   {
-    return __registerJmbParam<T>(iParamID, std::move(iChangeCallback));
     return maybeInvokeCallback(__registerJmbParam<T>(iParamID, iChangeCallback),
                                iChangeCallback,
                                iInvokeCallback);

src/cpp/pongasoft/VST/GUI/ViewCxMgr.h

@@ -88,7 +88,7 @@ class ViewCxMgr : private IViewListenerAdapter
 {
 public:
   /**
-   * @param TView should be a subclass of VSTGUI::CView
+   * @tparam TView should be a subclass of VSTGUI::CView
    * @return a pointer (owned by this class) to an object for registering callbacks, listener and params.
    *         Note: You should not keep this pointer around. It is owned by this class and will automatically be deleted
    *         when the view goes away.