Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions on how to execute the data preparation #125

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

maurerle
Copy link
Collaborator

minor fixes for current pandas version

see #21 for details

minor fixes for current pandas version
@jokochems
Copy link
Member

Hello @maurerle,

thanks a ton for your effort. I checked it out. Unfortunately, it seems to be not compatible with the older package versions I'm using (numpy 1.22.3 to be more precise). As it is not complete anyways, I suggest to keep this PR open for now until all problems with older package versions are/can be resolved. What do you think? Does this make sense to you?

Again many thanks and best regards,
Johannes

@maurerle
Copy link
Collaborator Author

Of course, sounds good.
Weird that this is not compatible, but no problem then.
This PR is more to prevent the "Yes I had problems too and have been a third through the script but do not remember what has to be changed" situation and document the issues :)

And hopefully it makes things easier when updating it :)

By the way I totally understand the situation of missing time for documentation and keeping repositories updated... :)

@jokochems jokochems marked this pull request as draft October 31, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants