-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exponential weighting on txn price limits #6
Conversation
Warning Rate limit exceeded@dshiell has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 30 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes made in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant FeeCalculator
Client->>Server: Initiate transaction
Server->>FeeCalculator: Check fees
FeeCalculator->>FeeCalculator: Compute new gas limits
FeeCalculator->>Server: Return fee status
Server->>Client: Respond with transaction status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
src/server.ts (1)
74-74
: Remove unnecessary empty linesThese empty lines don't serve any purpose and should be removed for better code organization.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/server.ts
(4 hunks)
🔇 Additional comments (1)
src/server.ts (1)
22-22
: Consider thread safety and rate limiting for limit adjustments
The current implementation modifies global state (TX_GASPRICE_LIMIT, TX_BLOBPRICE_LIMIT) during request processing, which could lead to race conditions in concurrent scenarios. Additionally, the exponential weighting system might need bounds to prevent runaway growth.
Consider:
- Using atomic operations or a mutex for limit updates
- Implementing a rate limiter for limit adjustments
- Adding upper bounds for maximum possible limits
- Persisting limit values to survive service restarts
Also applies to: 65-67, 89-90, 96-97
Summary by CodeRabbit
New Features
TX_ALPHA
for better fee calculations.Bug Fixes