Override dense hessian behavior #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfergus
approved these changes
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 87.27% 88.81% +1.53%
==========================================
Files 48 51 +3
Lines 2028 2002 -26
==========================================
+ Hits 1770 1778 +8
+ Misses 258 224 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
teseoch
reviewed
Jan 7, 2024
src/polysolve/nonlinear/Problem.hpp
Outdated
| virtual void hessian(const TVector &x, TDenseHessian &hessian) | ||
| { | ||
| THessian sparse_hessian; | ||
| this->hessian(x, sparse_hessian); |
|
This was implemented in #66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dense hessian calls a finite difference routine. This makes it rely on the sparse hessian.