Auth

[AntoineDao]

This PR addresses generating packaged tar files without using a filesystem (for server side packaging) and optional authentication (from library and CLI).

fixes #93
fixes #95
fixes #96

[AntoineDao]

Also managed to sneak in some code to replace all version keys with tag to solve #95

[mostaphaRoudsari]

Thanks. Looks good! My only major comment is about the pollination command under auth. I think we should move it to the plugin itself. The core library should not have plugin specific commands IMO.

[mostaphaRoudsari]

I believe this should be added from queenbee-pollination not in pollination itself. Otherwise we will have to add several plugin commands to the core library.

[AntoineDao]

This is just a command to add "pollination" style Auth to the queenbee config file. It will not serve as an entry point for other pollination commands.

[mostaphaRoudsari]

I understand that this is not the entry point command but don't you agree that this is a plugin specific command?

What stops you to move this command to queenbee-pollination? You can import add and then add your new command when queenbee-pollination is loaded. Right?

[AntoineDao]

Yeah it does kinda feel like a plugin command. The difficulty I'm having is not with integrating the click/cli side as a plugin but managing passing the config object which contains an Pollination api token and can create a JWT token that is then used to authenticate certain requests within recipes.

Essentially if I make this command a plugin then it feels I have to make this class which then makes it difficult (I think) to handle authentication to pollination servers when managing recipe dependencies. Part of the reason this is difficult is because we don't (currently) implement standard authentication mechanisms which we can expect to be reusable by other non-pollination servers.

[AntoineDao]

I'm in agreement about moving pollination stuff into plugins in general. In this case however I'm not 100% sure of what the best way to integrate special Auth requirements into non-plugin commands. In this case it felt acceptable much like the way Docker provides default auth methods for Dockerhub.

[AntoineDao]

@mostaphaRoudsari I am going to merge this after having fixed the styling issues. I am in agreement with you about plugin based loading of pollination specific commands and modules/functions however it will take me time to think about and implement a decent plugin system that I won't yell at and rip apart in 2 weeks time.

I have raised #98 to track this issue and we can plan some work to remove pollination specific modules and commands (it's only 1 class and one command for now) from queenbee.

[ladybugbot]

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

• GitHub release
• v1.14.0

Your semantic-release bot 📦🚀