Unhandled panic on read if the byte array is not appropriate size

[askuric]

Here is an example of the error happening: (support-poulpe branch but the same behavior can happen in any branch)

[ 3765.847074] reachy2-beta2 docker[1742]: core  | [ros2_control_node-1] thread '<unnamed>' panicked at /home/reachy/.cargo/git/checkouts/rustypot-999c9e34d6064e19/02a9b9f/src/device/mx.rs:37:1:
[ 3765.847130] reachy2-beta2 docker[1742]: core  | [ros2_control_node-1] called `Result::unwrap()` on an `Err` value: []

This is caused by these lines:

rustypot/src/device/mod.rs

Lines 20 to 21 in 72e7e8d

	let val = io.read(serial_port, id, $addr, size_of::<$reg_type>().try_into().unwrap())?;
	let val = $reg_type::from_le_bytes(val.try_into().unwrap());

Basically if the received data from io.read are not the same size as the size of $reg_type the val.try_into().unwrap() will panic because val.try_into() will return an error which will then be unwrapped.

In my case I could only reproduce the case where the io.read returns and empty byte vector, I am not sure if other cases where the byte vector would be too small or too large can happen.

[askuric]

Fixed with #53