New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep valid info when a sync read timeout? #19

Open

pierre-rouanet opened this issue Jan 17, 2023 · 0 comments

Labels

Member

pierre-rouanet commented Jan 17, 2023

When a timeout occurs in a sync read command, we know which values we've got and which are missing.
We could returns a Vec<Option<Vec> for instance.

Pros:

we don't throw away good values

Cons:

This will most likely make the API more complex.

pierre-rouanet added the enhancement label

pierre-rouanet mentioned this issue

Implement timeout on sync read for protocol v1 #20

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment