Resize popup for consistent size on Windows and Mac OS #1242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the differences in the way that Windows and Mac OS renders the window frames and borders it results in inconsistent popup sizes which obscures some information. e.g. the "Ask again later" option as shown below for Windows. This only happens when a popup is created and not when clicking on the extension icon.
chrome.windows.create
doesn't have a clean way to handle both OS's. This PR is a hacky way to try to handle both OS's.Original
chrome.windows.create
outer dimensions = 560x621 (fromPOPUP_WINDOW_OPTS
)Resulting Windows popup inner dimension = 544x582
After resize to 560x600 inner dimension