Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add French mnemonic file #1689

Closed
wants to merge 1 commit into from

Conversation

poka-IT
Copy link

@poka-IT poka-IT commented Dec 6, 2022

No description provided.

@jacogr
Copy link
Member

jacogr commented Dec 6, 2022

This will actually not get used as coded in this PR. The reasons being -

  1. The WASM bip39 execution path is the one that gets executed in 99.9% of the cases (JS is only used as a fallback when WASM is not available in the environment)
  2. The actual JS code here only used the DEFAULT_WORDLIST import (I believe CI will actually complain about the unused import here)

So basically with this is won't do anything. There is a way to do multiple languages, but it won't be simple.

  1. The WASM environment needs to take a wordlist as input (the bonus is that this reduces bundle size, i.e. currently both the WASM and JS environment has a copy)
  2. Execution needs to use this list
  3. The same logic for specification should happen in the JS environment (it could be as simple as setWordlist(...) before execution happens)

Overall, since each list adds to the bundle sizes (which is a huge ongoing problem), it will therefore need to be up to the developer using it to specify, instead of "having all available always".

@poka-IT
Copy link
Author

poka-IT commented Dec 6, 2022

I know it's a big job.
Do you have plans (I mean the team) to do this soon ?
Just to know, i'm Dart dev, not very comfortable with TS.

@jacogr
Copy link
Member

jacogr commented Dec 6, 2022

The team is basically me for anything and everything in polkadot-js. It is certainly something I want to do since "injecting the wordlist" results in a nice footprint drop (I did get the Rust bip39 dev to make the required changes to his lib), but it has only been hovering with no action taken. The reality is that most probably unless there is a PR that comes in with all the moving parts, it will take "forever" to get to.

(It is also not even logged, i.e. it only exists in my mind, see https://github.com/polkadot-js/wasm/issues)

@jacogr
Copy link
Member

jacogr commented Jan 25, 2023

The way to introduce this has been logged polkadot-js/wasm#452 - once available we can have this functionality.

@jacogr jacogr closed this Jan 25, 2023
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants