-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kusama: remove migrations applied by spec_version: 1_000_000
#73
Kusama: remove migrations applied by spec_version: 1_000_000
#73
Conversation
spec_version: 1_000_000
spec_version: 1_000_000
The 1st commit is the mandatory one, it removes the The other ones' removal at this point is optional, but if we see them applied on-chain, let's also remove them. |
Co-authored-by: Bastian Köcher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only remove from Kusama?
I'm thinking we do separate PRs that follow actual on-chain upgrades + migrations for each chain. When kusama is upgraded and we can verify these migrations have been successful we'll merge PR to remove them. My suggestions is same process, different PR+timeline for Polkadot. |
referenda for upgrading Kusama: https://kusama.subsquare.io/referenda/297 |
Kusama now successfully updated to Please note, we have to remove the session keys migration before the next release as it doesn't gracefully handle reapplying it. |
…ma-remove-applied-migrations
@andresilva please a rank-3 review here to get this in and avoid accidents like on Westend |
hmm.. since this touches fellows, please review! |
/merge |
…ma-remove-applied-migrations
…iu/runtimes into kusama-remove-applied-migrations
I just rebased and fixed conflicts. Someone with merge rights, pls take a look and merge before we keep adding new stuff and start confusing already applied migrations with incoming new ones. |
/merge |
Enabled Available commands
For more information see the documentation |
473498c
into
polkadot-fellows:main
this got auto-merged after rebase without running all CI tests - any way we can see if these failed or simply didn't run or what? 😃 |
You can check the CI build on master after this got merged. |
Runtimes 1.0.0 has been released: https://github.com/polkadot-fellows/runtimes/releases/tag/v1.0.0 and Kusama has now successfully updated on-chain to spec:
1_000_000
.This PR removes migrations that have been applied by the successful update of the Kusama runtime to above version.