Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch clippy from +nightly to $RUST_STABLE_VERSION #489

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Switch clippy from +nightly to $RUST_STABLE_VERSION #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec8b84e
Switch clippy from +nightly to $RUST_STABLE_VERSION
bkontur Oct 18, 2024
2b8e769
Merge branch 'main' into bko-clippy-stable
bkontur Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/clippy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,19 @@ jobs:
- name: Set rust version via common env file
run: cat .github/env >> $GITHUB_ENV

- name: Install nightly toolchain
run: rustup toolchain install "nightly-$RUST_NIGHTLY_VERSION" --profile minimal --component clippy
- name: Install stable toolchain
run: |
rustup toolchain install $RUST_STABLE_VERSION --profile minimal --component clippy
cargo --version
cargo clippy --version

- name: Fetch cache
uses: Swatinem/rust-cache@a95ba195448af2da9b00fb742d14ffaaf3c21f43 # v2.7.0
with:
shared-key: "fellowship-cache-clippy"

- name: Clippy
run: cargo +nightly-$RUST_NIGHTLY_VERSION clippy --all-targets --locked -q
run: cargo clippy --all-targets --locked -q
env:
RUSTFLAGS: "-D warnings"
SKIP_WASM_BUILD: 1
1 change: 0 additions & 1 deletion relay/kusama/src/governance/origins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

pub use pallet_custom_origins::*;

#[allow(unreachable_patterns)]
#[frame_support::pallet]
pub mod pallet_custom_origins {
use crate::{Balance, GRAND, QUID};
Expand Down
1 change: 0 additions & 1 deletion relay/polkadot/src/governance/origins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

pub use pallet_custom_origins::*;

#[allow(unreachable_patterns)]
#[frame_support::pallet]
pub mod pallet_custom_origins {
use crate::{Balance, DOLLARS, GRAND};
Expand Down
1 change: 0 additions & 1 deletion system-parachains/collectives/collectives-polkadot/src/ambassador/origins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

//! The Ambassador Program's origins.

#[allow(unreachable_patterns)]
#[frame_support::pallet]
pub mod pallet_origins {
use crate::ambassador::ranks;
Expand Down
1 change: 0 additions & 1 deletion system-parachains/collectives/collectives-polkadot/src/fellowship/origins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use super::ranks;
pub use pallet_origins::*;

#[allow(unreachable_patterns)]
#[frame_support::pallet]
pub mod pallet_origins {
use super::ranks;
Expand Down
Loading