-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coretime chain: allow region transfers #483
base: main
Are you sure you want to change the base?
Conversation
/cmd bench --runtime coretime-kusama --pallet pallet_xcm |
@bkontur lets test it and see :) i'm still testing everything on polkadot-sdk as it's more often used there |
@bkontur but here you don't need to call 2 times, only 1 time with all needed pallets and runtimes |
@mordamax I can see now at least that bot reacted with emoji, so something is happening, also I found: Would it be possible for the bot to post a comment with a link to the actual job, or is this something we want to avoid to prevent spamming PRs?
|
yep, seems like runner isn't working @bkchr ? or the name has changed? |
Would be great if we could merge this. Is the issue with benchmarking resolved? @mordamax |
Review required! Latest push from author must always be reviewed |
/cmd bench --runtime coretime-kusama --pallet pallet_xcm |
@mordamax https://github.com/polkadot-fellows/runtimes/actions/runs/11440472067/job/31826493274
|
the real error is here
|
@Szegoo what's the status of this PR? |
@seadanda The PR is ready; however, we need to generate weights.
|
The benchmark code was left blank even though the Region transactor is included in both Polkadot and Kusama: link.
Because of this, it is not possible to perform cross-chain transfers of regions since the weight is set to the maximum value: weight