Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coretime chain: allow region transfers #483

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Oct 14, 2024

The benchmark code was left blank even though the Region transactor is included in both Polkadot and Kusama: link.

Because of this, it is not possible to perform cross-chain transfers of regions since the weight is set to the maximum value: weight

@bkontur
Copy link
Contributor

bkontur commented Oct 15, 2024

/cmd bench --runtime coretime-kusama --pallet pallet_xcm
/cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@bkontur
Copy link
Contributor

bkontur commented Oct 15, 2024

/cmd bench --runtime coretime-kusama --pallet pallet_xcm
/cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@mordamax Is this working? Is it possible to use bot/cmd to update/regenerate weights for
coretime-kusama/coretime-polkadot pallet_xcm?

@mordamax
Copy link
Contributor

@bkontur lets test it and see :) i'm still testing everything on polkadot-sdk as it's more often used there

@mordamax
Copy link
Contributor

@bkontur but here you don't need to call 2 times, only 1 time with all needed pallets and runtimes

@bkontur
Copy link
Contributor

bkontur commented Oct 15, 2024

@mordamax I can see now at least that bot reacted with emoji, so something is happening, also I found:
https://github.com/polkadot-fellows/runtimes/actions/runs/11343705292/job/31546944434

Would it be possible for the bot to post a comment with a link to the actual job, or is this something we want to avoid to prevent spamming PRs?

Waiting for a runner to pick up this job... still waiting more than 13 minutes.

image

@mordamax
Copy link
Contributor

yep, seems like runner isn't working @bkchr ? or the name has changed?
I can't see these settings to check

@Szegoo
Copy link
Contributor Author

Szegoo commented Oct 21, 2024

Would be great if we could merge this. Is the issue with benchmarking resolved? @mordamax

Copy link

Review required! Latest push from author must always be reviewed

@bkchr
Copy link
Contributor

bkchr commented Oct 21, 2024

/cmd bench --runtime coretime-kusama --pallet pallet_xcm
/cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@bkontur
Copy link
Contributor

bkontur commented Oct 23, 2024

/cmd bench --runtime coretime-kusama --pallet pallet_xcm /cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@mordamax https://github.com/polkadot-fellows/runtimes/actions/runs/11440472067/job/31826493274

ReferenceError: Cannot access 'jobUrl' before initialization
    at eval (eval at callAsyncFunction (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:8:53)
    at callAsyncFunction (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35425:12)
    at main (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35522:26)
    at /opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35497:1
    at /opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35553:3
    at Object.<anonymous> (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35556:12)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
Error: Unhandled error: ReferenceError: Cannot access 'jobUrl' before initialization

@mordamax
Copy link
Contributor

/cmd bench --runtime coretime-kusama --pallet pallet_xcm /cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@mordamax https://github.com/polkadot-fellows/runtimes/actions/runs/11440472067/job/31826493274

ReferenceError: Cannot access 'jobUrl' before initialization
    at eval (eval at callAsyncFunction (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:8:53)
    at callAsyncFunction (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35425:12)
    at main (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35522:26)
    at /opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35497:1
    at /opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35553:3
    at Object.<anonymous> (/opt/github-runner/_work/_actions/actions/github-script/v7/dist/index.js:35556:12)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
Error: Unhandled error: ReferenceError: Cannot access 'jobUrl' before initialization

the real error is here

Run sudo apt update && sudo apt install --assume-yes \
sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper
sudo: a password is required

@bkchr pinged @tugytur in matrix to check the runner

@seadanda
Copy link
Contributor

@Szegoo what's the status of this PR?

@Szegoo
Copy link
Contributor Author

Szegoo commented Dec 23, 2024

@seadanda The PR is ready; however, we need to generate weights.

/cmd bench --runtime coretime-kusama --pallet pallet_xcm
/cmd bench --runtime coretime-polkadot --pallet pallet_xcm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants