Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain approval rights #42

Merged
merged 10 commits into from
Oct 30, 2023
Merged

Explain approval rights #42

merged 10 commits into from
Oct 30, 2023

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 25, 2023

This also adds a tutorial on how to add the github name to the on-chain identity.

This also adds a tutorial on how to add the github name to the on-chain identity.
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the description! I will add github identity feild soon

.github/review-bot.yml Show resolved Hide resolved
.github/review-bot.yml Show resolved Hide resolved
Co-authored-by: joe petrowski <[email protected]>
Copy link
Contributor

@Bullrich Bullrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! I also ran the config file on the cli to find issues and the validator didn't find any problems 👍

.github/review-bot.yml Show resolved Hide resolved
Bullrich added a commit to paritytech/get-fellows-action that referenced this pull request Sep 29, 2023
docs/github-on-chain-identity.md Outdated Show resolved Hide resolved
docs/github-on-chain-identity.md Outdated Show resolved Hide resolved
docs/github-on-chain-identity.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there was a requirement about adding the onchain address to github bio or something like that. Is it no longer required? Otherwise, would be good to document as well.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bkchr
Copy link
Contributor Author

bkchr commented Oct 10, 2023

I remember there was a requirement about adding the onchain address to github bio or something like that. Is it no longer required? Otherwise, would be good to document as well.

That is not a requirement of any of this logic. This was only required for the initial seeding.

bkchr and others added 2 commits October 10, 2023 22:52
Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
Bullrich added a commit to paritytech/get-fellows-action that referenced this pull request Oct 25, 2023
Bullrich added a commit to paritytech/get-fellows-action that referenced this pull request Oct 25, 2023
This was copied from
polkadot-fellows/runtimes#42

It adds an explanation to the readme on how to add your github handle to
your identity.
@bkchr bkchr merged commit dd7f86f into main Oct 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants