-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secretary Program #347
Open
Doordashcon
wants to merge
51
commits into
polkadot-fellows:main
Choose a base branch
from
Doordashcon:ddc-secretary-collective2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Secretary Program #347
Doordashcon
wants to merge
51
commits into
polkadot-fellows:main
from
Doordashcon:ddc-secretary-collective2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Tested with Chopsticks |
muharem
reviewed
Aug 8, 2024
muharem
reviewed
Aug 8, 2024
system-parachains/collectives/collectives-polkadot/src/secretary/origins.rs
Outdated
Show resolved
Hide resolved
muharem
reviewed
Aug 8, 2024
bkchr
approved these changes
Nov 19, 2024
system-parachains/collectives/collectives-polkadot/src/secretary/mod.rs
Outdated
Show resolved
Hide resolved
} | ||
|
||
impl pallet_salary::Config<SecretarySalaryInstance> for Runtime { | ||
type WeightInfo = (); // TODO weights::pallet_salary_secretary_salary::WeightInfo<Runtime>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weights are still missing.
@joepetrowski @muharem please give it another review that we can merge this. |
eskimor
approved these changes
Nov 20, 2024
xlc
approved these changes
Nov 21, 2024
bkchr
reviewed
Nov 21, 2024
@Doordashcon the benchmarks are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes polkadot-fellows/help-center#10
On Chain Structure
The on-chain program consists of one rank(
SECRETARY
) and the default Candidate(SECRETARY_CANDIDATE
):Membership Management
Members themselves are without the power to promote or demote, this right is reserved to token holders via Polkadot OpenGov and votes from
Fellow
rank of the Technical Fellowship.