Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

im-online cleanup: phase 1 #267

Merged

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn commented Apr 8, 2024

This PR removes migrations and transient code connected with im-online removal. It introduces an offchain db cleanup migration that must be removed later.

  • Does not require a CHANGELOG entry

@s0me0ne-unkn0wn
Copy link
Contributor Author

Currently, this PR suffers from a versioning problem (it requires pallet-im-online version 30.0.0, which brings in diverged dependencies). I'll wait until the 1.3.0 version bumps are complete before proceeding with this one.

@s0me0ne-unkn0wn s0me0ne-unkn0wn marked this pull request as ready for review July 12, 2024 09:14
@s0me0ne-unkn0wn
Copy link
Contributor Author

s0me0ne-unkn0wn commented Jul 12, 2024

It's finally unblocked by bumping SDK to 1.13
CC @ordian

Copy link
Contributor

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last phase would be removing this code?

@s0me0ne-unkn0wn
Copy link
Contributor Author

The last phase would be removing this code?

Exactly, and after that we're done (I'm expecting some big celebration in connection with that event)

@ordian
Copy link
Contributor

ordian commented Jul 19, 2024

cc @eskimor @sandreim

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bkchr
Copy link
Contributor

bkchr commented Jul 19, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit d0855a4 into polkadot-fellows:main Jul 19, 2024
45 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@s0me0ne-unkn0wn s0me0ne-unkn0wn deleted the im-online-cleanup1 branch July 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants