Check and fix features #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
reviewed
Feb 27, 2024
.cargo/config.toml
Outdated
| "-Aclippy::derivable_impls", # false positives | ||
| "-Aclippy::stable_sort_primitive", # prefer stable sort | ||
| "-Aclippy::extra-unused-type-parameters", # stylistic | ||
| "-Aclippy::all", |
There was a problem hiding this comment.
we could also move this to the main Cargo.toml with [workspace.lints.clippy] and [workspace.lints.rust],
and set for every Cargo.toml:
[lints]
workspace = true
There was a problem hiding this comment.
Yea agreed, will do in another MR.
bkontur
approved these changes
Feb 27, 2024
muharem
approved these changes
Mar 4, 2024
joepetrowski
approved these changes
Mar 15, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
force-pushed
the
oty-feature-check
branch
from
a8dfa39 to
c7aaa0e
Compare
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
xlc
approved these changes
Mar 27, 2024
acatangiu
approved these changes
Mar 27, 2024
bkchr
approved these changes
Mar 27, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Trimmed this MR down to only do feature changes and no formatting anymore, to reduce conflicts.
Changes:
[x] Does not require a CHANGELOG entry