Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove shared key for cache and add cache for migrations #142

Merged
merged 16 commits into from
Jan 17, 2024

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Jan 11, 2024

PR removes shared key for rust-cache action. When 2 different workflows use the same shared-key they try to use the same destination for cache which makes it unusable for them (they have race condition who will be the first to write there). Also PR adds cache for migration jobs and cancelling jobs on previous runs.

cc #134

@alvicsam alvicsam changed the title [DNM] test cache in ci [ci] Remove shared key for cache and add cache for migrations Jan 12, 2024
@alvicsam alvicsam mentioned this pull request Jan 12, 2024
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alvicsam
Copy link
Contributor Author

fyi, I don't have the Merge button

@ggwpez
Copy link
Member

ggwpez commented Jan 16, 2024

Error: unable to get latest version

Now it fails

fyi, I don't have the Merge button

Yea normally you can type /merge, but for these simple ones we just merge them manually.

@alvicsam
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 16, 2024 12:18
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 418a2a9 into polkadot-fellows:main Jan 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants