Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fellowship entities get free xcm execution #107

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Nov 30, 2023

Fellowship entities get free xcm execution.

Same as the Fellowship entities allowed to pass UnpaidExecution command to bypass the fees charged by Trader impl, we include the Fellowship locations to WaivedLocations to not be charged by FeeManager impl.

@muharem muharem mentioned this pull request Nov 30, 2023
Copy link
Contributor

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to have good tests setup. I just don't like those PR changes important parameters and no tests to ensure it does the right thing.

@muharem
Copy link
Contributor Author

muharem commented Dec 1, 2023

We really need to have good tests setup. I just don't like those PR changes important parameters and no tests to ensure it does the right thing.

For sure. I did test this with xcm-emulator in Westend env. I know @NachoPal is working on setting up an env for the runtimes in this env.

@bkchr
Copy link
Contributor

bkchr commented Dec 1, 2023

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) December 1, 2023 15:47
@fellowship-merge-bot fellowship-merge-bot bot merged commit b8df4b0 into polkadot-fellows:main Dec 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants