disallow tweaking sub-ids from any proxy

polkadot-fellows · Dec 23, 2024 · c2d3b05 · c2d3b05
1 parent 2e73a6c
commit c2d3b05
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/system-parachains/people/people-kusama/src/lib.rs b/system-parachains/people/people-kusama/src/lib.rs
@@ -492,7 +492,11 @@ impl InstanceFilter<RuntimeCall> for ProxyType {
 				c,
 				RuntimeCall::Balances { .. } |
 				// `request_judgement` puts up a deposit to transfer to a registrar
-				RuntimeCall::Identity(pallet_identity::Call::request_judgement { .. })
+				RuntimeCall::Identity(pallet_identity::Call::request_judgement { .. }) |
+				// `set_subs`, `add_sub`, `quite_sub` will take and repatriate deposits from the proxied account, should not be allowed.
+				RuntimeCall::Identity(pallet_identity::Call::add_sub { .. }) |
+				RuntimeCall::Identity(pallet_identity::Call::set_subs { .. }) |
+				RuntimeCall::Identity(pallet_identity::Call::quit_sub { .. })
 			),
 			ProxyType::CancelProxy => matches!(
 				c,

diff --git a/system-parachains/people/people-polkadot/src/lib.rs b/system-parachains/people/people-polkadot/src/lib.rs
@@ -456,7 +456,11 @@ impl InstanceFilter<RuntimeCall> for ProxyType {
 				c,
 				RuntimeCall::Balances { .. } |
 				// `request_judgement` puts up a deposit to transfer to a registrar
-				RuntimeCall::Identity(pallet_identity::Call::request_judgement { .. })
+				RuntimeCall::Identity(pallet_identity::Call::request_judgement { .. }) |
+				// `set_subs`, `add_sub`, `quite_sub` will take and repatriate deposits from the proxied account, should not be allowed.
+				RuntimeCall::Identity(pallet_identity::Call::add_sub { .. }) |
+				RuntimeCall::Identity(pallet_identity::Call::set_subs { .. }) |
+				RuntimeCall::Identity(pallet_identity::Call::quit_sub { .. })
 			),
 			ProxyType::CancelProxy => matches!(
 				c,