Skip to content

Commit

Permalink
Lower approval requirements
Browse files Browse the repository at this point in the history
This pull requests lowers the approval requirements until we have a more
sophisticated tool. So, that we could do assign a voting power per rank
and then require that X amount of voting power. This would then mean
that may 3 rank II approvals having the same voting power as rank III.
  • Loading branch information
bkchr committed Nov 16, 2023
1 parent 5d98c2e commit 629dfcb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/review-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ rules:
include:
- ^\.github/.*
type: fellows
minRank: 4
minRank: 3
minApprovals: 2
- name: Relay and system files
condition:
Expand All @@ -13,8 +13,8 @@ rules:
- ^system-parachains\/.*
- ^CHANGELOG.md$
type: fellows
minRank: 3
minApprovals: 4
minRank: 2
minApprovals: 3
- name: General Files
condition:
include:
Expand All @@ -25,4 +25,4 @@ rules:
- ^\.github/.*
- ^CHANGELOG.md$
type: fellows
minRank: 2
minRank: 1
2 changes: 1 addition & 1 deletion .github/workflows/review-trigger.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Review-Trigger

on:
on:
pull_request_target:
types:
- opened
Expand Down

0 comments on commit 629dfcb

Please sign in to comment.