Skip to content

Commit

Permalink
[encointer] fix missing hook for enactment of proposals (#508)
Browse files Browse the repository at this point in the history
The first 4 Encointer democracy proposals have been up for vote and two
proposals have been approved. However, we realized that enactment did
not happen. This is due to a missing hook in the runtime.

This PR should fix the hook and enact the already approved after the
next runtime upgrade when the cycle phase changes to "assigning"
  • Loading branch information
brenzi authored Dec 18, 2024
1 parent c05f20f commit 5b61c46
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

- Fix missing Encointer democracy pallet hook needed for enactment ([polkadot-fellows/runtimes/pull/508](https://github.com/polkadot-fellows/runtimes/pull/508))

### Added

- Location conversion tests for relays and parachains ([polkadot-fellows/runtimes#487](https://github.com/polkadot-fellows/runtimes/pull/487))
Expand Down
4 changes: 3 additions & 1 deletion system-parachains/encointer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,9 @@ parameter_types! {

impl pallet_encointer_scheduler::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type OnCeremonyPhaseChange = EncointerCeremonies;
// attention!: EncointerDemocracy must be first hook as it potentially changes the rules for
// following hooks
type OnCeremonyPhaseChange = (EncointerDemocracy, EncointerCeremonies);
type MomentsPerDay = MomentsPerDay;
type CeremonyMaster = MoreThanHalfCouncil;
type WeightInfo = weights::pallet_encointer_scheduler::WeightInfo<Runtime>;
Expand Down

0 comments on commit 5b61c46

Please sign in to comment.