Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OnCheckEvmTransaction callback #1106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: OnCheckEvmTransaction callback #1106

wants to merge 3 commits into from

Conversation

fairax
Copy link
Contributor

@fairax fairax commented Jul 11, 2023

This change would allow adding of custom fee handling logic. For example we are using it to withdraw fee from sponsor instead of transaction sender.

@fairax fairax requested a review from sorpaas as a code owner July 11, 2023 07:42
@fairax fairax changed the title Add OnCheckEvmTransaction callback feat: OnCheckEvmTransaction callback Jul 11, 2023
@fairax fairax force-pushed the feature/on_check_evm_transaction branch 3 times, most recently from ff532e7 to 1e3d30a Compare July 12, 2023 10:10
@fairax fairax force-pushed the feature/on_check_evm_transaction branch 2 times, most recently from 91f543a to 6fad7d4 Compare July 20, 2023 13:08
sorpaas
sorpaas reviewed Jul 30, 2023
View reviewed changes
frame/evm/src/lib.rs Outdated Show resolved Hide resolved
@fairax fairax force-pushed the feature/on_check_evm_transaction branch from 6fad7d4 to 07cf3bd Compare September 10, 2023 16:15
@fairax fairax requested a review from sorpaas September 10, 2023 17:36
@fairax fairax force-pushed the feature/on_check_evm_transaction branch from 777cabe to 9e2a82f Compare September 11, 2023 07:22
@fairax fairax force-pushed the feature/on_check_evm_transaction branch from 9e2a82f to 6699f36 Compare September 13, 2023 05:52
@fairax fairax force-pushed the feature/on_check_evm_transaction branch from 6699f36 to 3fce932 Compare September 21, 2023 07:24
@fairax fairax force-pushed the feature/on_check_evm_transaction branch from 3fce932 to 23b2427 Compare October 17, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boundless-forest boundless-forest boundless-forest left review comments

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@yjhmelody yjhmelody Awaiting requested review from yjhmelody

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A7-gotissues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairax @sorpaas @boundless-forest @yjhmelody