This repository has been archived by the owner on Mar 1, 2021. It is now read-only.
Students homework android #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otopba
suggested changes
Mar 3, 2019
|
|
||
| public class MainActivity extends AppCompatActivity { | ||
|
|
||
| private List<Student> students; | ||
| private EditText surName, name; |
There was a problem hiding this comment.
Тут конечно на любителя, но тут можно и не сокращать названия переменных и не писать несколько в строчку
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
| setContentView(R.layout.activity_main); | ||
| Objects.requireNonNull(getSupportActionBar()).hide(); |
| } | ||
|
|
||
| private int getRandomPhoto(boolean maleGender) { | ||
| if (maleGender) |
|
|
||
| private void onStudentClick(View view, int i) { | ||
| if (index != -1) { | ||
| if (checkFields()) |
| if (index != -1) { | ||
| if (checkFields()) | ||
| if (isDataSaved()) | ||
| Toast.makeText(MainActivity.this, "Вам следует сохранить изменения", Toast.LENGTH_SHORT).show(); |
There was a problem hiding this comment.
Если есть желание, то перенеси все строки в ресурсы
|
|
||
| private void setBorderVisibility(View view, int visible) { | ||
| if (view != null) { | ||
| view.findViewById(R.id.student_item__top).setVisibility(visible); |
There was a problem hiding this comment.
Не очень хорошо каждый раз искать вью по айди. Лучше один раз найти и запомнить
| Toast.makeText(MainActivity.this, "Студент сохранён", Toast.LENGTH_SHORT).show(); | ||
| studentAdapter.notifyDataSetChanged(); | ||
| } | ||
|
|
| nameTextView.setText(String.valueOf(student.getSecondName() + " " + student.getFirstName())); | ||
| avatarImageView.setImageResource(student.getPhoto()); | ||
| } | ||
|
|
| android:layout_height="match_parent" | ||
| android:fillViewport="true" | ||
| tools:ignore="ExtraText,UselessParent"> | ||
| > |
| @@ -1,9 +1,201 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Зачем тут релатив, если у тебя скрол вью во весь экран?
|
@otopba fixed |
otopba
reviewed
Mar 4, 2019
| else | ||
| if (checkFields()) { | ||
| if (isDataSaved()) { | ||
| Toast.makeText(MainActivity.this, getResources().getString(R.string.userShouldSave_warning), Toast.LENGTH_SHORT).show(); |
There was a problem hiding this comment.
1)Можно писать просто this
2) Toast.makeText может принимать вторым аргументом прямо id строки: R.string.userShouldSaveCreated_warning
| } | ||
|
|
||
| private boolean isDataSaved() { | ||
| return students.get(index).getFirstName().trim().length() == 0 || students.get(index).getSecondName().trim().length() == 0; | ||
| } | ||
|
|
||
| private boolean checkFields() { | ||
| if (name.getText().toString().trim().length() > 0 && surName.getText().toString().trim().length() > 0) |
There was a problem hiding this comment.
Лучше всегда расставлять фигурные скобки
| app:layout_constraintBottom_toBottomOf="@id/guideline_horizontal" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" /> | ||
|
|
|
Работа принята. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.