This repository has been archived by the owner on Mar 1, 2021. It is now read-only.
Students | Vadim Dyachkov #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otopba
suggested changes
Mar 3, 2019
|
|
||
| private void init(Context context) { | ||
| LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE); | ||
| View view = inflater.inflate(R.layout.student_view, this, false); |
There was a problem hiding this comment.
Что бы не писать addView(view); можно третим аргументов поставить true
| @Override | ||
| public void onClick(View v) { | ||
| if (student != null) { | ||
| student.setFirstName(firstNameTv.getText().toString()); |
There was a problem hiding this comment.
firstNameTv.getText() иногда возвращает null
| hideBtn.setOnClickListener(new OnClickListener() { | ||
| @Override | ||
| public void onClick(View v) { | ||
| onHide.onClick(v); |
There was a problem hiding this comment.
Во всех лисенерах нет проверки на нул. Если не был установлен лисенер
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class StudentsRepository { |
There was a problem hiding this comment.
Для данного задания такое решение подходит. Но в перспективе если с репозиторием будет работать не один поток будут проблемы
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
|
|
||
| <View |
There was a problem hiding this comment.
"Разделитель" между списком и формой студента
|
@otopba fixed |
otopba
reviewed
Mar 3, 2019
| @@ -60,33 +59,39 @@ private void init(Context context) { | |||
| saveBtn.setOnClickListener(new OnClickListener() { | |||
| @Override | |||
| public void onClick(View v) { | |||
| CharSequence firstName = firstNameTv.getText(); | |||
| CharSequence secondName = secondNameTv.getText(); | |||
| if (firstName == null || firstName.length() == 0 || secondName == null || secondName.length() == 0) { | |||
There was a problem hiding this comment.
Можно проверять с помощью TextUtils.isEmpty()
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
|
|
||
| <View |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.