Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP,ENH] Add FSL first level estimator #365

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented May 3, 2022

Add the first level FSL estimator

TODO:

  • calculate p-values
  • handle F-contrasts
  • interleave F-contrast output with T-contrasts to preserve original order
  • write more interface tests
  • fix FILMGLS interface to grab outputs correctly
  • pin an actual nipype release
  • make FSL installation smaller (optional)

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #365 (8c97b23) into dev (c65b7d2) will decrease coverage by 59.83%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #365       +/-   ##
==========================================
- Coverage   64.42%   4.59%   -59.84%     
==========================================
  Files          23      24        +1     
  Lines        1816    1871       +55     
  Branches      343     340        -3     
==========================================
- Hits         1170      86     -1084     
- Misses        564    1785     +1221     
+ Partials       82       0       -82     
Impacted Files Coverage Δ
fitlins/cli/run.py 0.00% <ø> (ø)
fitlins/interfaces/fsl.py 0.00% <0.00%> (ø)
fitlins/workflows/base.py 0.00% <0.00%> (-59.14%) ⬇️
fitlins/utils/config.py 0.00% <0.00%> (-100.00%) ⬇️
fitlins/utils/strings.py 0.00% <0.00%> (-100.00%) ⬇️
fitlins/utils/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
fitlins/workflows/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
fitlins/interfaces/abstract.py 0.00% <0.00%> (-100.00%) ⬇️
fitlins/interfaces/afni.py 0.00% <0.00%> (-86.72%) ⬇️
fitlins/interfaces/utils.py 0.00% <0.00%> (-83.08%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65b7d2...8c97b23. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants