fix:fix POLARIS_CONFIG_IP is the same as POLARIS_CONFIG_PORT BUG #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuntaojun
requested changes
Jul 8, 2024
chuntaojun
requested changes
Jul 8, 2024
| envs[javaEnvIndex] = corev1.EnvVar{ | ||
| Name: "JAVA_TOOL_OPTIONS", | ||
| Value: oldVal + " " + fmt.Sprintf(ActiveJavaAgentCmd, opt.ExternalInfo[customJavaAgentVersion]), | ||
| if _, valid := oldAgentVersions[annonations[customJavaAgentVersion]]; !valid { |
There was a problem hiding this comment.
270～279和285～295的代码优化下，重复的逻辑有嗲多
added 2 commits
July 8, 2024 19:24
chuntaojun
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
Fixes #188
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.