Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading delta tables #190

Closed
wants to merge 2 commits into from
Closed

Conversation

Bidek56
Copy link
Collaborator

@Bidek56 Bidek56 commented Mar 25, 2024

Adding support for reading delta tables thru Rust deltalake
To close #176

@@ -27,6 +27,7 @@ thiserror = "1"
smartstring = { version = "1" }
serde_json = { version = "1" }
either = "1.9"
deltalake = "0.17.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit hesitant to add this in as a dependency.

this pulls in the entire arrow-rs project as well as many other heavy dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, I will keep looking for alternatives. Thx

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think the "ideal" approach would be first to upstream some work to delta-rs and expose a javascript library. Then we could use the JS library directly like py-polars does, and do a bunch of the logic on the JS side using apache-arrow as an optional dependency.

If the apache-arrow npm package becomes a point of contention, we could likely bypass it by dynamically linking to the delta js bindings directly.

Copy link
Collaborator Author

@Bidek56 Bidek56 Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delta-rs team is busy with C# implementation now. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was effort to use delta-sharing using JS and Danfo.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for reading Delta tables
2 participants