-
Notifications
You must be signed in to change notification settings - Fork 605
Solaris 11 support #99
base: master
Are you sure you want to change the base?
Conversation
Any feedback on this PR? |
@ccope I can't test this easily so I'm not sure I'm super comfortable supporting it internally. |
Yeah... I put in the work to create a bento packer definition for automatically generating Solaris 11 base boxes, but unfortunately it doesn't seem possible to distribute prebuilt boxes right now :-( https://github.com/opscode/bento/blob/master/packer/solaris-11-x86.json |
Even with that, my testing harness is built on docker+travis. So this would have to be manually tested. |
Ah... Well, that's kind of a bummer. Though the cookbook does currently support FreeBSD and SmartOS (a Solaris derivative), which also do not run in Docker containers, I can see the concern of adding more untested code. Given that the scope of the change is so small though, would you consider merging this if I added a disclaimer to the README like this?
|
Yeah, thats probably reasonable. |
Hmm. Well, I added the notice. Looks like berkshelf is having some unrelated issues right now which broke the build (failed to download the minitest cookbook). |
0b15bfe
to
ea212c3
Compare
@coderanger it looks like any new PR's will fail testing until my last commit gets merged |
b1efb76
to
6716009
Compare
rebased on master, fixed build again |
Virtual machine is best tool to cross platforms. |
Leaving this open for tracking, this should get moved to a provider subclass in https://github.com/poise/poise-python. Will revisit shortly. |
The default recipe and pip_package provider work just fine after adding the package names. I didn't test the source recipe but I suspect it won't work without gmake (GNU make instead of the Sun make).