Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example details page #1017

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Nov 13, 2024

feat: add example details page

What does this PR do?

  • Adds clickable example details pages
  • Tests for said pages
  • Clickable link to source repo

Screenshot / video of UI

Screenshot 2024-11-13 at 9 10 34 AM

Screen.Recording.2024-11-13.at.9.10.14.AM.mov

What issues does this PR fix or reference?

Closes #974

Follow up issue is #1016

How to test this PR?

Click "More Details" on one of the examples

Signed-off-by: Charlie Drage [email protected]

### What does this PR do?

* Adds clickable example details pages
* Tests for said pages
* Clickable link to source repo

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#974

Follow up issue is podman-desktop#1016

### How to test this PR?

<!-- Please explain steps to reproduce -->

Click "More Details" on one of the examples

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage requested a review from a team as a code owner November 13, 2024 15:22
@cdrage cdrage requested review from benoitf, feloy and axel7083 and removed request for a team November 13, 2024 15:22
Copy link

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a little comment

packages/frontend/src/lib/ExampleCard.svelte Outdated Show resolved Hide resolved
@cdrage cdrage enabled auto-merge (squash) November 15, 2024 13:35
@cdrage cdrage merged commit 09d248c into podman-desktop:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation: View readme of image example within extension
3 participants