Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Transcript voice selection rework #1466

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eteubert
Copy link
Member

@eteubert eteubert commented May 18, 2024

Goals

  • by default, if no contributor is assigned/selected, the transcript still works by defaulting to the voice string from the vtt file (instead of an empty transcript)
  • add a dedicated option to hide a voice from a transcript

Notes

  • I would usually use something like -1 for special cases but since contributor_id is an unsigned int, I use 4294967295 -- which should at least be turned into a constant in the final implementation for readability
  • Think about how this change affects users: Not selecting a contributor is not an intended feature, but people may be using it to hide contributors. After this update they might then have unwanted voices appearing in their transcripts.

@eteubert eteubert changed the title Spike: Transcript voice selection rework Proposal: Transcript voice selection rework May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant