Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(podcastindex): expose guid as href attribute on podcast:person tag #1195

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from

Conversation

saerdnaer
Copy link
Contributor

@saerdnaer saerdnaer commented Feb 28, 2021

Additionally, the PR improves UX of the contributor form:

And last but not least – the change actually described by the PR title:

  • setting the href attribute on the exiting <podcast:person>-Tag in the podcast feed to the value of the URI=guid field

image

initial PR description

I would propose do automatically fill the guid field in the wp_podlove_modules_contributors_contributor table with the first social media URL, once it is added in the Wordpress backend. Maybe even just in the UI via JavaScript – so for example when I add the users twitter handle in the social table and the URI Field above is empty (looks like URI is the form's label for the guid database field) then it should be automatically filled with the full URL as it is behind the arrow button in the table.

Maybe also add an database migration which automatically does this for all existing entries c.f. #939 (comment)

UPDATE wp_podlove_modules_contributors_contributor c 
  LEFT JOIN wp_podlove_modules_social_contributorservice cs ON c.id = cs.contributor_id
  LEFT JOIN wp_podlove_modules_social_service s ON s.id = cs.service_id 
SET c.guid = CONCAT('https://twitter.com/', cs.value) 
WHERE c.guid IS NULL AND s.type = 'twitter'

Related to #939 & podlove/podlove-specifications#23

@douglaskastle
Copy link
Contributor

If this is to be the case, is it possible to add an "other" as a service to allow any URL to used? Right now podchaser (for example) is not supported, so currently I would like that. However the bigger picture is, I don't know what i might want down the road, and it might not be supported (IMDB is one I have looked at)

Ultimately the href on the person is meant to be more of a central identifier, like linkedIn, IMDB, podchaser than a social service like twitter, deviantart. Facebook is werid here, it is kinda used for both.

@saerdnaer
Copy link
Contributor Author

@eteubert eteubert added this to the 3.6 milestone Apr 12, 2021
@saerdnaer saerdnaer force-pushed the fix-person branch 2 times, most recently from 503feef to ffc3bd0 Compare June 6, 2021 21:05
@saerdnaer
Copy link
Contributor Author

If this is to be the case, is it possible to add an "other" as a service to allow any URL to used? Right now Podchaser (for example) is not supported, so currently I would like that.

Actually, this PR supports any service implementing WebFinger. But yes, as Podchaser now has a proper API, we could also add a feature to lookup persons by name there – but we would somehow mange the api keys problem. But thats a different discussion and PR. :-)

@eteubert
Copy link
Member

@saerdnaer Are you still planning to continue working on this? Not sure about the state of the implementation but I vaguely remember it wasn't finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants