refactor(HMS-2191): remove metrics openapi #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisiedo
force-pushed
the
hms-2191-fix-metrics
branch
from
a5ea997 to
b0e4479
Compare
avisiedo
changed the title
avisiedo
force-pushed
the
hms-2191-fix-metrics
branch
from
b0e4479 to
10aea8f
Compare
This change remove metrics.openapi.* files, and update Makefile according to that. This is a special case as the /openapi.json endpoint, and to achieve this to work, the openapi file becomes invalid with the specification for the path of the endpoint; be aware the /metrics path could differ and the port where it will be listening, depending on the clowder configuration. Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-2191-fix-metrics
branch
from
10aea8f to
7368ecb
Compare
tiran
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remove metrics.openapi.* files, and update Makefile according to that.
This is a special case as the /openapi.json endpoint, and to achieve this to work, the openapi file becomes invalid with the specification for the path of the endpoint; be aware the /metrics path could differ and the port where it will be listening, depending on the clowder configuration.