Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'use' statements for argument types #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schmengler
Copy link

This fixes two warnings on startup

PHP Warning: Declaration of TiB\PatchPal\Magento\Command\AbstractCommand::execute(TiB\PatchPal\Magento\Command\InputInterface $input, TiB\PatchPal\Magento\Command\OutputInterface $output) should be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) in /[...]/.modman/pocallaghan_magerun-patchpal/src/Magento/Command/AbstractCommand.php on line 121

PHP Warning: Declaration of TiB\PatchPal\Magento\Command\CompatCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) should be compatible with TiB\PatchPal\Magento\Command\AbstractCommand::execute(TiB\PatchPal\Magento\Command\InputInterface $input, TiB\PatchPal\Magento\Command\OutputInterface $output) in /[...]/.modman/pocallaghan_magerun-patchpal/src/Magento/Command/CompatCommand.php on line 12

as well as a fatal error

PHP Fatal error: Uncaught TypeError: Argument 1 passed to TiB\PatchPal\Magento\Command\AbstractCommand::validateChangesetSource() must be an instance of TiB\PatchPal\Magento\Command\InputInterface, instance of Symfony\Component\Console\Input\ArgvInput given, called in /[...]/.modman/pocallaghan_magerun-patchpal/src/Magento/Command/CompatCommand.php on line 32 and defined in /[...]/.modman/pocallaghan_magerun-patchpal/src/Magento/Command/AbstractCommand.php:45

(with PHP 7.1 and Symfony console 3.4.11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant