Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rather than just being treated as empty regex, broken filter regex should signal via UI. #6

Open
pobocks opened this issue Mar 15, 2016 · 0 comments

Comments

@pobocks
Copy link
Owner

pobocks commented Mar 15, 2016

As a user who's using raw regex input, I should get different behavior when I have nothing in the filter and when I have some broken or incomplete regex, like:

wang(chung

My initial thought is to implement an "error" visual state for the filter, and enter/exit it based on filter state.

I think this is only relevant for the raw regex search mode - I don't think token mode can be broken in this way, because tokens are all regex-quoted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant