-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use utf8 strings as mem cache keys #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Nov 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 57 57
Lines 2871 2872 +1
=======================================
+ Hits 2661 2662 +1
Misses 210 210 ☔ View full report in Codecov by Sentry. |
Micro-Benchmark ResultsLinux
|
Integrated-Benchmark Report (Linux)Scenario: Frozen Lockfile
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 0.1271716063466667,
"stddev": 0.009812358487650672,
"median": 0.12619836648,
"user": 0.060102726666666675,
"system": 0.2001150733333333,
"min": 0.11450732448000002,
"max": 0.14428669348,
"times": [
0.14428669348,
0.11990778348000002,
0.12619836648,
0.13605476948,
0.12718388648,
0.11450732448000002,
0.12066137548000001,
0.13758830448,
0.12542734648,
0.12743158148,
0.13692406248,
0.11953791848000002,
0.14075418748000001,
0.11592374748000002,
0.11518674748000002
],
"exit_codes": [
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
]
},
{
"command": "pacquet@main",
"mean": 0.12316214754666668,
"stddev": 0.009758218348705645,
"median": 0.12175780848000001,
"user": 0.05872752666666667,
"system": 0.20377233999999997,
"min": 0.10750951548000001,
"max": 0.13768289148,
"times": [
0.13554187048,
0.11585921048000002,
0.13768289148,
0.11726989848000001,
0.11095596748000001,
0.11996457548000002,
0.12027272148000001,
0.13042775948,
0.11030591948000001,
0.13455231048,
0.12728008348,
0.12497080248000002,
0.12175780848000001,
0.13308087848,
0.10750951548000001
],
"exit_codes": [
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
]
}
]
} |
zkochan
approved these changes
Nov 28, 2023
That's fine. Neither pnpm nor the other node.js based alternatives support non-utf8 chars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the use of
OsString
was to allow non-UTF8 paths. However, the index file feature requiresserde
which in turns require UTF-8 to serialize. So the need forOsString
ceases to be necessary, and removing it open new opportunities for some micro-optimizations.