Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add taplo #163

Merged
merged 4 commits into from
Oct 28, 2023
Merged

ci: add taplo #163

merged 4 commits into from
Oct 28, 2023

Conversation

KSXGitHub
Copy link
Contributor

  • Add taplo to CI.
  • Add allow_blank_lines = 1 to taplo config.

KSXGitHub
KSXGitHub commented Oct 28, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.03      9.6±4.27ms   453.5 KB/sec    1.00      9.3±4.03ms   467.5 KB/sec

@github-actions
Copy link

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 214.7 ± 20.3 183.1 238.9 1.07 ± 0.14
pacquet@main 200.4 ± 17.2 180.6 222.9 1.00

zkochan
zkochan reviewed Oct 28, 2023
View reviewed changes
crates/fs/Cargo.toml
homepage.workspace = true
keywords.workspace = true
license.workspace = true
repository.workspace = true

Copy link
Member

@zkochan zkochan Oct 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this alignment with fixed width before =. It means that if there is a new field with a longer length, then all the other unrelated lines will be changed too, making diffs bigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkochan I tried removing align_width = true from .taplo.toml before making this PR. The Cargo.toml files look messy without column alignment, so I decided to keep it as it is.

@zkochan zkochan merged commit 6477502 into main Oct 28, 2023
9 checks passed
@zkochan zkochan deleted the change-taplo branch October 28, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSXGitHub @zkochan