Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: integrated-benchmark #159

Merged
merged 47 commits into from
Oct 26, 2023
Merged

ci: integrated-benchmark #159

merged 47 commits into from
Oct 26, 2023

Conversation

KSXGitHub
Copy link
Contributor

@KSXGitHub KSXGitHub commented Oct 19, 2023

Limitations

  • Statistical outliers: Caused by other jobs still running in parallel. The current workaround is to re-run the job. To completely fix this however, this benchmark must be set to be after all other jobs have been completed, which requires touching other workflows.
  • No windows: Executing this on Windows CI is just too hard: cannot use powershell because of execution policy, and cannot use bash because it points to WSL which causes error.
  • No macOS: The benchmark values are too chaotic and unreliable.
  • No clean install yet: It's too slow.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.02     10.5±5.32ms   412.5 KB/sec    1.00     10.3±3.84ms   419.3 KB/sec

@KSXGitHub KSXGitHub changed the title ci: add integrated-benchmark for ubuntu-latest ci: integrated-benchmark Oct 19, 2023
@github-actions

This comment was marked as outdated.

@KSXGitHub KSXGitHub force-pushed the benchmark-to-ci branch 2 times, most recently from 10b97a3 to b3918e6 Compare October 19, 2023 19:38
@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 152.4 ± 16.1 129.5 188.0 1.09 ± 0.15
pacquet@main 139.9 ± 12.3 124.9 158.1 1.00

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Integrated-Benchmark Report (macOS)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 831.8 ± 148.7 627.0 1082.4 1.07 ± 0.30
pacquet@main 773.9 ± 167.6 565.1 1145.6 1.00

@KSXGitHub KSXGitHub marked this pull request as ready for review October 22, 2023 14:01
@zkochan zkochan merged commit 5c866cd into main Oct 26, 2023
13 checks passed
@zkochan zkochan deleted the benchmark-to-ci branch October 26, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants