Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for HeaderTypes as new PageTitle WebPart in OneColumnFullWIth is not always in first section #1066

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix check for HeaderTypes as new PageTitle WebPart in OneColumnFullWIth is not always in first section #1066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectClientSidePages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,8 @@ private void CreatePage(Web web, ProvisioningTemplate template, TokenParser pars
}
case ClientSidePageHeaderType.Default:
{
//Message ID: MC791596 / Roadmap ID: 386904
if (clientSidePage.Sections.Any() && clientSidePage.Sections.First().Type == CanvasSectionType.OneColumnFullWidth &&
clientSidePage.Sections.First().Controls.Any(c => c.Type == WebPartType.PageTitle))
//Message ID: MC791596 / Roadmap ID: 386904 =>based on #1058 the PageTitle WebPart is not always in first section
if (clientSidePage.Sections.Any(s => s.Type == CanvasSectionType.OneColumnFullWidth && s.Controls.Any(c => c.Type == WebPartType.PageTitle)))
{
page.SetPageTitleWebPartPageHeader();
}
Expand Down
Loading