-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added adaptor method and one test #27
Conversation
I am not familiar with pytest, so I am not sure if I incorporated pytest correctly. |
Taking a look, I'll test things and report back if something needs to be fixed. |
Okay @janisshin, so to finish out the pytest file, we will need to add an actual Then we can use some @pytest.mark.parametrize("antimony_path", [
"path/to/your/antimony/model1.ant",
])
def test_antimony_to_cobra_conversion(antimony_path):
... you can save the Once you make these changes, you can run the script with |
Perfect, let me check to see if it runs on my end. If it's something small not working, I can fix it so we don't need to go back and forth again. Then I can review and merge. Thanks for this addition! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made one more change to fix some small issues, but test passes now. Merging.
Added a method to emll/util.py for converting Antimony models into a form that is compatible with Cobra.
Also added a test for this method which checks to see whether the stoichiometric matrices match after conversion