Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created LICENSE #52

Closed
wants to merge 2 commits into from
Closed

Created LICENSE #52

wants to merge 2 commits into from

Conversation

ranwitter
Copy link

Added Perl5 License to support SCA Toolchains like Synopsis Blackduck.

Without this License most automatic SCA Toolchains says no License detected.

Added Perl5 License to support SCA Toolchains like Synopsis Blackduck. 

Without this License most automatic SCA Toolchains says no License detected.
@pmqs pmqs self-assigned this Nov 7, 2023
@pmqs
Copy link
Owner

pmqs commented Nov 7, 2023

Thanks for the patch, but the GNU license is not appropriate for this code.

@ranwitter
Copy link
Author

Thanks for the patch, but the GNU license is not appropriate for this code.

Which License do you suggest ?

@pmqs
Copy link
Owner

pmqs commented Nov 7, 2023

The Perl artistic License 2.0 (https://opensource.org/license/artistic-2-0/) applies to this module.

What issue is this solving?

in MD5 Format for easy rendering
@pmqs
Copy link
Owner

pmqs commented Nov 28, 2023

Does the file not have to contain the complete license text? Perhaps add a link to the definitive source, like https://www.perlfoundation.org/artistic-license-20.html ? Does that still keep the automatic checkers happy?

@ranwitter
Copy link
Author

Most automated SCA Tools scan for distributed verbatim copies of license document and hence a Link is not sufficient.

@pmqs
Copy link
Owner

pmqs commented Nov 28, 2023

Most automated SCA Tools scan for distributed verbatim copies of license document and hence a Link is not sufficient.

Hmm, but this isn't verbatim copy of the licence file. You have changed the formatting and added peoples names.

Are you aware that this code is also shipped with the official Perl distribution, which (I think) has a licence file. Does that matter for your use case?

Also - there are modules that are included by IO::Compress, namely Compress::Raw::Zlib and Compress::Raw::Bzip2, Does your automation not flag them as well?

@ranwitter
Copy link
Author

All three Modules are detected currently as shown in screenshots. Please kindly see.
blackduck_sbom_perl_modules_compress_20231128

blackduck_sbom_perl_modules_io_compress20231128
blackduck_sbom_perl_modules_compress_raw_zlib_20231128
blackduck_sbom_perl_modules_compress_raw_bzip_20231128

@ranwitter ranwitter closed this Nov 28, 2023
@ranwitter ranwitter reopened this Nov 28, 2023
@ranwitter
Copy link
Author

In our use case we have deployed all three modules above, downloaded from CPAN.org and dynamically linked under PERL5LIB.

@rwp0
Copy link
Contributor

rwp0 commented Nov 29, 2023

@ranwitter please consider adding the below to your initial post:

Fixes #53

(to link the PR and Issue together)

@Grinnz
Copy link

Grinnz commented Nov 29, 2023

As posted on the p5p mailing list:

Artistic 1 and 2 are separate licenses that cannot be interchanged, and unfortunately Perl is licensed with "Artistic 1.0 OR GPL 1+", which cannot reasonably be changed. As the license of this distribution appears to be "same as Perl itself", the generated LICENSE file should match this. The easiest way to generate such a file correctly is with the software-license program https://metacpan.org/pod/App::Software::License:

software-license --holder 'Paul Marquess' --year 1995 --license Perl_5 --type license > LICENSE

(you can edit the generated year to the year range as listed in the docs, but the application seems to require an integer)

@pmqs
Copy link
Owner

pmqs commented Nov 29, 2023

@ranwitter I've had a chat with the Perl community about this.

Given that this code has a dual life, namely distributed on CPAN and also bundled with Perl itself, it complicates things a bit.

The Perl license is also dual nature, in that you can choose either the Artistic or GNU license. Me picking one for IO-Compress would complicate the Perl bundle.

The current recommendation therefore is to have this

This software is copyright (c) 1995-2023 by Paul Marquess.

This is free software; you can redistribute it and/or modify it under
the same terms as the Perl 5 programming language system itself.

As it happens I already have that exact wording the top of the README file.

Can your automation be told to look for this in the README file?

@ranwitter
Copy link
Author

Thank you for the kind investigation. Yes SCA tool can be redirected to look into README file.

@ranwitter ranwitter closed this Dec 5, 2023
@ranwitter ranwitter deleted the patch-1 branch December 5, 2023 07:15
@ranwitter ranwitter mentioned this pull request Dec 5, 2023
@pmqs
Copy link
Owner

pmqs commented Dec 5, 2023

Thank you for the kind investigation. Yes SCA tool can be redirected to look into README file.

Excellent! Good to hear that you have it sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants