fix #117: resizing buffer before rearranging elements into "safe buff…

…er space"

packages/uikit/package.json

@@ -27,7 +27,7 @@
     "./internals": "./dist/internals.js"
   },
   "scripts": {
-    "test": "mocha ./tests/flex.spec.ts",
+    "test": "mocha ./tests/*.spec.ts",
     "build": "node --loader ts-node/esm scripts/extract-core-component-properties.ts && tsc -p ./tsconfig.build.json",
     "generate": "node --loader ts-node/esm scripts/flex-generate-setter.ts",
     "check:prettier": "prettier --check src scripts tests",

packages/uikit/src/panel/instanced-panel-group.ts

@@ -269,11 +269,17 @@ export class InstancedPanelGroup {
     if (this.elementCount > this.bufferElementSize) {
       //buffer is to small to host the current elements
       this.resize()
+      //we need to execute updateSortedBucketsAllocation after resize so that updateSortedBucketsAllocation has enough space to arrange all the elements
+      updateSortedBucketsAllocation(this.buckets, this.activateElement, this.bufferCopyWithin)
     } else if (this.elementCount <= this.bufferElementSize / 3) {
+      //we need to execute updateSortedBucketsAllocation first, so we still have access to the elements in the space that will be removed by the resize
+      //TODO: this could be improved since now we are re-arraging in place and then copying. we could rearrange while copying. Not sure if faster though?
+      updateSortedBucketsAllocation(this.buckets, this.activateElement, this.bufferCopyWithin)
       //buffer is at least 300% bigger than the needed space
       this.resize()
+    } else {
+      updateSortedBucketsAllocation(this.buckets, this.activateElement, this.bufferCopyWithin)
     }
-    updateSortedBucketsAllocation(this.buckets, this.activateElement, this.bufferCopyWithin)
     this.mesh!.count = this.elementCount
     this.mesh!.visible = true
   }

packages/uikit/tests/allocation.spec.ts

@@ -16,14 +16,12 @@ function createSortedBuckets(data: Float32Array, buckets: Array<Bucket<Element>>
   const activateElement = (element: Element, bucket: Bucket<Element>, index: number) => {
     data[bucket.offset + index] = element.value
     element.index = index
-    console.log('activate', element.value, 'at', bucket.offset, '/', index, ':', ...data)
   }
   const setElementIndex = (element: Element, index: number) => {
     element.index = index
   }
   const copyBufferWithin = (targetIndex: number, startIndex: number, endIndex: number) => {
     data.copyWithin(targetIndex, startIndex, endIndex)
-    console.log('copy ', startIndex, '-', endIndex, 'to', targetIndex, ':', ...data)
   }
   return {
     add(value: number, bucketIndex: number): Element {