-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update dependencies, normalize testing #607
Conversation
|
31e5ba6
to
903eb97
Compare
⭐ Update Since I don't have access to the pmndrs Vercel account, I cannot check to see what's up, but it might be related. Although it's odd how it has worked before in that case. @drcmda, any chance you could have a look? A dump of the build error on Vercel would be nice, too. |
Hey @wiledal I can help with vercel debugging! Looks like the last build failed on this:
|
I'll try updating the node.js version in vercel and re-running 🙂 |
ok, now the vercel deployment is up to a new error
|
Thanks @isaac-mason! I'm just back from a vacay 🌴. I'm trying to reproduce this error on Vercel on a forked repo. Could you let me know what the Vercel project's Edit: Ah, I think I got it now.
Getting the same errors, will fiddle a bit to see if I can find a solution. Edit 2: I can get this working when configuring
It will be compiling "from source", though I'm not sure how preconstruct deals with the built packages in this context, or if it really matters... That being said, it would be great knowing why rollup fails to build packages after updating the unrelated testing suite. |
I've updated the pmndrs react-three-rapier vercel app to have the same configuration now 🙂 I'm not very familiar with preconstruct either, would be good to understand. |
Built and deployed successfully! https://react-three-rapier-jjahtxe68-pmndrs.vercel.app/ |
Description
Add .yarnrc.yml to support yarn 4Problems with this update:
requestAnimationFrame
, which breaks testing when running tests outside of a browser environmenthappy-dom
orjsdom
environmentthree-stdlib
(common dependency in all r3/* libs) has alottiejs
implementation which is optimized for ssr, and does some canvas operations immediately when run in a browser environment. This breaks tests.jsdom
, and applyvitest-canvas-mock
in the setup-filedemo
breaks when updating any of these libraries.happy-dom
tojsdom
breaks Vercel deploymentvitest
to the latest version breaks Vercel deploymentAs I personally don't have access to the Vercel deployment logs or settings, it's nearly impossible to replicate. It's very odd that the testing suite, which is not even run on Vercel, would be affecting the deployment.
Further work is needed to make this up to date with current versions of all the dependent software.
Type of change
Checklist: