Major changes for adding Exchanges #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitted to prepare adding of additional exchanges
|
I'll look this over in the near future. It's a larger change than most so will accept it after giving it a read. |
|
Finally it´s done and tested 😃 Pair reload time: I needed to rewrite a file from gdax python and many more threads but watchdog is handling all of them and it´s working good for me with a total of 14% CPU Load |
Changed Gdax Lib to use Websocket
pmaji
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn´t sleep so it was time to create a new Class!
New features:
-If execution is fast enough we pull exactly every 500 ms from GDAX by taking timestamp of last pull and comparing it with current stamp, and if dif < 500 ms sleep the needed time.
-ticker in Class to open space for more exchanges
-refresh worker and prepare separated to enable constant prepare regardless of refresh worker.
-refresh worker split into refreshworkerGDAX to open space for future Exchanges
Additionally I deleted 2nd GDAX API pull, because initial idea to have the price after time consumption by code execution is not aplicable due to est. 8s until next refresh.
So saving 80ms but delaying overall refresh by 5s is bad.
Needed for #29