Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: cubiod -> cuboid #643

Closed
wants to merge 1 commit into from

Conversation

fotonick
Copy link

Ultra-simple search-and-replace typo fix. cargo test passes. No benchmark changes. No doc layout changes. Link from contributors guide to plotters/examples/wasm-demo is broken, but there's hardly any room for a search-and-replace to break it, so I request a waiver.

@AaronErhardt
Copy link
Member

As simple as this change might seem, I can't merge this currently because on the main branch we don't accept breaking changes. Only on next-release-devel we do.

@fotonick
Copy link
Author

I see. I didn't know about next-release-dev since it wasn't mentioned in CONTRIBUTING.md. Looking at this branch, I see that this identical patch was committed two years ago in c836474. I'm a little concerned that it hasn't made its way to main in that time. Either way, this PR is redundant. Closing.

@fotonick fotonick closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants