Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill to fix context-menu extension in Safari #201

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

emilykl
Copy link
Contributor

@emilykl emilykl commented Nov 30, 2023

About

The cytoscape-context-menu extension causes a breaking "Illegal Constructor" error in Safari (see issue here).

Screen Shot 2023-11-30 at 10 18 17 AM
This can be fixed by adding an existing polyfill to the project.

Description of changes

This PR adds the necessary polyfill to fix the "Illegal Constructor" error in Safari.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Steps to test

  1. Check out branch
  2. Run npm install && npm run build:all
  3. Run the context menu demo Dash app: python demos/usage-context-menu.py and navigate to http://127.0.0.1:8050 in Safari
  4. If the app loads properly without an "Illegal Constructor" Javascript error, all is good.

@emilykl emilykl requested a review from cleaaum November 30, 2023 17:51
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

Copy link
Contributor

@cleaaum cleaaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine on safari!

@emilykl emilykl merged commit b070ded into master Nov 30, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants