Fix the completer in Jupyterlab 4 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edublancas
requested changes
Dec 23, 2023
|
awesome! the CI is failing but I merged it anyway since the base thanks a lot for working on this! |
brichet
added a commit
to brichet/jupysql-plugin
that referenced
this pull request
Dec 27, 2023
edublancas
added a commit
that referenced
this pull request
Jan 8, 2024
* fix formatting for jupyterlab 4 * upgrades dependencies * completer compatible with jupyter 4 (we need to connect it to the keywords) * fix * updates * updates index, removes highighting since it no longer works * adds sample codeeditor plugin * applying syntax highlighting * highlight working * clean up syntax highlighting * Fix the completer in Jupyterlab 4 (#99) * Fixes dependencies * Refactore syntax highlight plugin * Test requirements * Update yarn3 command * Update build dependencies in pyproject.toml * Fix jest * update snapshots * Remove syntax highlight (back from rebase), handles now by plugin_editor * update snapshots * last snapshot * Clean syntax highlighting plugin * Parameterized tests for completer --------- Co-authored-by: Eduardo Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fix the SQL completion for jupyterlab 4
Issue number
Related to ploomber/jupysql#930
Checklist before requesting a review
pkgmt format