Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

54 connector widget special chars #83

Closed
wants to merge 7 commits into from
Closed

54 connector widget special chars #83

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c73653
fix connector widget special chars
bryannho Sep 27, 2023
2b756ef
changelog,docstring, unit tests
bryannho Sep 29, 2023
de9521d
duplicate tests
bryannho Sep 30, 2023
804cee3
fix test errors
bryannho Oct 2, 2023
062472f
edit connect test
bryannho Oct 2, 2023
1086f48
test fixes
bryannho Oct 3, 2023
125862c
retry CI
bryannho Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/utils/helper-functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
export const specialToASCII = (str: string): string => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a docstring

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

let res = '';
for(let i = 0; i < str.length; i++) {
if(+str[i] || str[i].toLowerCase() !== str[i].toUpperCase()){
res += str[i];
continue;
}
else if (str[i] === ' ') {
res += '_';
continue;
}
res += str[i].charCodeAt(0);
};
return res;
};
7 changes: 4 additions & 3 deletions src/widgets/connector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {

import { MODULE_NAME, MODULE_VERSION } from '../version';

import { specialToASCII } from '../utils/helper-functions';

// Import the CSS
import '../../style/connector.css';
Expand Down Expand Up @@ -155,7 +156,7 @@ export class ConnectorView extends DOMWidgetView {
// Draw connection buttons
connections.forEach((connection: Connection) => {
const { name } = connection;
const name_without_spaces = name.replace(/ /g, "_");
const name_without_spaces = specialToASCII(name)

const buttonContainer = document.createElement("DIV");
buttonContainer.className = "connection-button-container";
Expand Down Expand Up @@ -339,7 +340,7 @@ export class ConnectorView extends DOMWidgetView {
deleteConnectionMessage.querySelector(".actions").appendChild(deleteButton);

// hide controllers
const deleteConnBtn = this.el.querySelector(`#deleteConnBtn_${connection["name"].replace(/ /g, "_")}`);
const deleteConnBtn = this.el.querySelector(`#deleteConnBtn_${specialToASCII(connection["name"])}`);
const actionsContainer = <HTMLElement>deleteConnBtn.parentNode;
actionsContainer.style.display = "none"

Expand Down Expand Up @@ -635,7 +636,7 @@ export class ConnectorView extends DOMWidgetView {
buttonEl.classList.add("secondary");
});

const selectedButtonEl = (<HTMLButtonElement>this.el.querySelector(`#connBtn_${connectionName.replace(/ /g, "_")}`));
const selectedButtonEl = (<HTMLButtonElement>this.el.querySelector(`#connBtn_${specialToASCII(connectionName)}`));
selectedButtonEl.innerText = "Connected";
selectedButtonEl.classList.add("primary");
}
Expand Down